Hi Guennadi, On 07/24/2013 01:36 PM, Guennadi Liakhovetski wrote: > On Mon, 22 Jul 2013, Sylwester Nawrocki wrote: >> Hello, >> >> This is a few patches for the v4l2-async API I wrote while adding >> the asynchronous subdev registration support to the exynos4-is >> driver. >> >> The most significant change is addition of V4L2_ASYNC_MATCH_OF >> subdev matching method, where host driver can pass a list of >> of_node pointers identifying its subdevs. >> >> I thought it's a reasonable and simple enough way to support device >> tree based systems. Comments/other ideas are of course welcome. > > Thanks for the patches. In principle I have nothing against them, OF > support looks good, integrating asdl into struct v4l2_subdev, dropping > redundant checks, renaming "bus" to "match look ok too. Plural vs. > singular seems to be a matter of taste to me :) But in general, provided > my single comment concerning struct forward-declaration is addressed Thanks for your review. I'm going to make that change locally, before sending a pull request with those patches. > Acked-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
