Hi Gueannadi, On 07/24/2013 01:26 PM, Guennadi Liakhovetski wrote: > On Mon, 22 Jul 2013, Sylwester Nawrocki wrote: > >> > This is a purely cosmetic change. Since the 'subdev' member >> > points to an array of subdevs it seems more intuitive to name >> > it in plural form. > > Well, I was aware of the fact, that "subdev" is an array and that the > plural form of "subdev" would be "subdevs" :-) It was kind of a conscious > choice. I think, both ways can be found in the kernel: using singulars and > plurals for array names. Whether one of them is better than the other - no > idea. My personal preference is somewhat with the singular form as in, say > "subdev array" instead of "subdevs array," i.e. as an adjective, but I > really don't care all that much :) Feel free to change if that's important > for you or for others on V4L :) Sorry, I expected this patch to be a bit controversial... :) I agree it might be a matter of taste, but subdev/num_subdevs pair bothered me quite a bit so I've decided to post the patch anyway. If you don't mind that much I'd like to keep that patch in this series. -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
