Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vladimir

On Wed, 24 Jul 2013, Vladimir Barinov wrote:

> Hi Guennadi,
> 
> Thank you for the v8 review.
> 
> On 07/24/2013 08:14 PM, Guennadi Liakhovetski wrote:
> > [snip]
> > > +	/* output format */
> > > +	switch (icd->current_fmt->host_fmt->fourcc) {
> > > +	case V4L2_PIX_FMT_NV16:
> > > +		iowrite32(ALIGN(cam->width * cam->height, 0x80),
> > > +			  priv->base + VNUVAOF_REG);
> > > +		dmr = VNDMR_DTMD_YCSEP;
> > > +		output_is_yuv = true;
> > > +		break;
> > > +	case V4L2_PIX_FMT_YUYV:
> > > +		dmr = VNDMR_BPSM;
> > > +		output_is_yuv = true;
> > > +		break;
> > > +	case V4L2_PIX_FMT_UYVY:
> > > +		dmr = 0;
> > > +		output_is_yuv = true;
> > > +		break;
> > > +	case V4L2_PIX_FMT_RGB555X:
> > > +		dmr = VNDMR_DTMD_ARGB1555;
> > > +		break;
> > > +	case V4L2_PIX_FMT_RGB565:
> > > +		dmr = 0;
> > > +		break;
> > > +	case V4L2_PIX_FMT_RGB32:
> > > +		if (priv->chip == RCAR_H1 || priv->chip == RCAR_E1) {
> > > +			dmr = VNDMR_EXRGB;
> > > +			break;
> > > +		}
> > > +	default:
> > > +		BUG();
> > as commented above, please, remove
> Does WARN_ON(1) work instead of removal?

Sorry, by "remove" I certainly meant replace with a proper handling, not 
just delete. In principle the above condition should never be entered, 
right? Also for fmt == V4L2_PIX_FMT_RGB32 but chip not one of RCAR_H1 or 
RCAR_E1? Well, this function is called from your driver's .buf_queue(), 
which doesn't return an error. But yes, I would make rcar_vin_setup() 
issue a warning and return an error and then, back in 
rcar_vin_videobuf_queue() return the buffer with an error code (goto 
error).

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux