Hello. On 07/24/2013 08:14 PM, Guennadi Liakhovetski wrote:
From: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy <phil.edworthy@xxxxxxxxxxx>.
Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id' values, reordered rcar_vin_id_table[] entries, removed senseless parens from to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to the *if* statement and used 'bool' values instead of 0/1 where necessary, removed unused macros, done some reformatting and clarified some comments.] Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
--- This patch is against the 'media_tree.git' repo.
Changes since version 7: - remove 'icd' field from 'struct rcar_vin_priv' in accordance with the commit f7f6ce2d09c86bd80ee11bd654a1ac1e8f5dfe13 ([media] soc-camera: move common code to soc_camera.c); - added mandatory clock_{start|stop}() methods in accordance with the commit a78fcc11264b824d9651b55abfeedd16d5cd8415 ([media] soc-camera: make .clock_ {start,stop} compulsory, .add / .remove optional).
Changes since version 6: - sorted #include's alphabetically once again; - BUG() on invalid format in rcar_vin_setup();
No, please don't. I think I commented on the use of BUG() in this driver already. It shall only be used if the machine cannot continue to run. I don't think this is the sace here.
Note that sh_mobile_ceu_camera.c has BUG() in almost the same case. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
