On 06/21/2013 02:27 PM, Prabhakar Lad wrote: > Hi Lars-Peter, > > On Sun, Jun 16, 2013 at 3:41 PM, Prabhakar Lad > <prabhakar.csengg@xxxxxxxxx> wrote: >> Hi Lars-Peter, >> >> Thanks for the patch. >> >> On Sat, Jun 15, 2013 at 8:04 PM, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote: >>> client->driver->id_table will always point to the first entry in the device id >>> table. So all devices will use the same init sequence. Use the id table entry >>> that gets passed to the driver's probe() function to get the right init >>> sequence. >>> >> The patch looks OK, but it causes following two warnings, >> >> drivers/media/i2c/tvp514x.c: In function 'tvp514x_s_stream': >> drivers/media/i2c/tvp514x.c:868: warning: unused variable 'client' >> drivers/media/i2c/tvp514x.c: In function 'tvp514x_probe': >> drivers/media/i2c/tvp514x.c:1092: warning: assignment makes pointer >> from integer without a cast >> > Do you plan to post a v2 ? or shall I take care of it ? > > Regards, > --Prabhakar Lad I'll send a v2 soon. - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
