Re: [PATCH] [media] tvp514x: Fix init seqeunce

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lars-Peter,

Thanks for the patch.

On Sat, Jun 15, 2013 at 8:04 PM, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
> client->driver->id_table will always point to the first entry in the device id
> table. So all devices will use the same init sequence. Use the id table entry
> that gets passed to the driver's probe() function to get the right init
> sequence.
>
The patch looks OK, but it causes following two warnings,

drivers/media/i2c/tvp514x.c: In function 'tvp514x_s_stream':
drivers/media/i2c/tvp514x.c:868: warning: unused variable 'client'
drivers/media/i2c/tvp514x.c: In function 'tvp514x_probe':
drivers/media/i2c/tvp514x.c:1092: warning: assignment makes pointer
from integer without a cast

With the above fixed you can add my,

Acked-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
Tested-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>

Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux