Hi Sakari,
Thanks for the review.
On Friday 07 June 2013 13:51:18 Sakari Ailus wrote:
> On Fri, Jun 07, 2013 at 12:35:41PM +0200, Laurent Pinchart wrote:
> > @@ -851,7 +857,11 @@ static int ccp2_s_stream(struct v4l2_subdev *sd, int
> > enable)>
> > ccp2_print_status(ccp2);
> >
> > /* Enable CSI1/CCP2 interface */
> >
> > - ccp2_if_enable(ccp2, 1);
> > + ret = ccp2_if_enable(ccp2, 1);
> > + if (ret < 0) {
> > + omap3isp_csiphy_release(ccp2->phy);
>
> if (ccp2->phy)
> omap3isp_csiphy_release(ccp2->phy);
>
> ?
>
> I don't think 3430 has a separate phy, so it's NULL.
Oops, my bad. Fixed in v2.
> > + return ret;
> > + }
> >
> > break;
> >
> > case ISP_PIPELINE_STREAM_SINGLESHOT:
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
