Re: [PATCH] omap3isp: ccp2: Don't ignore the regulator_enable() return value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for the patch, Laurent!

On Fri, Jun 07, 2013 at 12:35:41PM +0200, Laurent Pinchart wrote:
> @@ -851,7 +857,11 @@ static int ccp2_s_stream(struct v4l2_subdev *sd, int enable)
>  		ccp2_print_status(ccp2);
>  
>  		/* Enable CSI1/CCP2 interface */
> -		ccp2_if_enable(ccp2, 1);
> +		ret = ccp2_if_enable(ccp2, 1);
> +		if (ret < 0) {
> +			omap3isp_csiphy_release(ccp2->phy);

if (ccp2->phy)
	omap3isp_csiphy_release(ccp2->phy);

?

I don't think 3430 has a separate phy, so it's NULL.

> +			return ret;
> +		}
>  		break;
>  
>  	case ISP_PIPELINE_STREAM_SINGLESHOT:

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@xxxxxx	XMPP: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux