Hi Arnd, Thank you for the patch. On Saturday 01 June 2013 00:22:50 Arnd Bergmann wrote: > The ispqueue.h file uses vm_flags_t, which is defined in > linux/mm_types.h, so we must include that header in order > to build in all configurations. > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx > Cc: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxx> > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> (with a minor nitpick below) > --- > drivers/media/platform/omap3isp/ispqueue.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/omap3isp/ispqueue.h > b/drivers/media/platform/omap3isp/ispqueue.h index 908dfd7..e6e720c 100644 > --- a/drivers/media/platform/omap3isp/ispqueue.h > +++ b/drivers/media/platform/omap3isp/ispqueue.h > @@ -31,6 +31,7 @@ > #include <linux/mutex.h> > #include <linux/videodev2.h> > #include <linux/wait.h> > +#include <linux/mm_types.h> Could you please make sure the headers are sorted alphabetically ? Would you like me to take the patch in my tree ? If so I'll sort the headers myself. > struct isp_video_queue; > struct page; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html