On Monday 13 May 2013 20:40:33 Wei Yongjun wrote: > On 05/13/2013 08:19 PM, Federico Vaga wrote: > > Hello, > > > > I agree with the content of the patch, but I disagree with the commit > > message.> > > >From the commit message it seems that you fixed a bug about the error > > >code, > > > > but the aim of this patch is to uniform the code style. I suggest > > something > > like: "uniform code style in sta2x11_vip_init_one()" > > The orig code will release all the resources if v4l2_device_register() > failed and return 0. > But what we need in this case is to return an negative error code > to let the caller known we are failed. So the patch save the return > value of v4l2_device_register() to 'ret' and return it when error. Oh sure, you are right :) I did not understand it immediately from the commit message. Can you put this answer as commit message? It is perfectly clear where is the bug now. Thank you -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
