Hello, I agree with the content of the patch, but I disagree with the commit message. >From the commit message it seems that you fixed a bug about the error code, but the aim of this patch is to uniform the code style. I suggest something like: "uniform code style in sta2x11_vip_init_one()" On Monday 13 May 2013 13:59:45 Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> > --- > drivers/media/pci/sta2x11/sta2x11_vip.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/pci/sta2x11/sta2x11_vip.c > b/drivers/media/pci/sta2x11/sta2x11_vip.c index 7005695..77edc11 100644 > --- a/drivers/media/pci/sta2x11/sta2x11_vip.c > +++ b/drivers/media/pci/sta2x11/sta2x11_vip.c > @@ -1047,7 +1047,8 @@ static int sta2x11_vip_init_one(struct pci_dev *pdev, > ret = sta2x11_vip_init_controls(vip); > if (ret) > goto free_mem; > - if (v4l2_device_register(&pdev->dev, &vip->v4l2_dev)) > + ret = v4l2_device_register(&pdev->dev, &vip->v4l2_dev); > + if (ret) > goto free_mem; > > dev_dbg(&pdev->dev, "BAR #0 at 0x%lx 0x%lx irq %d\n", -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
