Re: [PATCH RFC] [media] blackfin: add video display driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sylwester ,

>> @@ -9,7 +9,18 @@ config VIDEO_BLACKFIN_CAPTURE
>>           To compile this driver as a module, choose M here: the
>>           module will be called bfin_capture.
>>
>> +config VIDEO_BLACKFIN_DISPLAY
>> +       tristate "Blackfin Video Display Driver"
>> +       depends on VIDEO_V4L2&&  BLACKFIN&&  I2C
>> +       select VIDEOBUF2_DMA_CONTIG
>> +       help
>> +         V4L2 bridge driver for Blackfin video display device.
>
>
> Shouldn't it just be "V4L2 output driver", why are you calling it "bridge" ?
>
Hmm, capture<->display, input<->output, right?
The kernel docs called it bridge, may "host" sounds better.

>> +/*
>> + * Analog Devices video display driver
>
>
> Sounds a bit too generic.
>
>> + *
>> + * Copyright (c) 2011 Analog Devices Inc.
>
>
> 2011 - 2013 ?
>
Written in 2011.

>> +struct disp_fh {
>> +       struct v4l2_fh fh;
>> +       /* indicates whether this file handle is doing IO */
>> +       bool io_allowed;
>> +};
>
>
> This structure should not be needed when you use the vb2 helpers. Please see
> below for more details.
>
The only question is how the core deal with the permission that which
file handle can
stream off the output. I want to impose a rule that only IO handle can stop IO.
I refer to priority, but current kernel driver export this to user
space and let user decide it.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux