Hi Laurent,
>> >> >> +struct mt9m114_reg {
>> >> >> + u16 reg;
>> >> >> + u32 val;
>> >> >> + int width;
>> >> >> +};
>> >> >> +
>> >> >> +enum {
>> >> >> + MT9M114_QVGA,
>> >> >> + MT9M114_VGA,
>> >> >> + MT9M114_WVGA,
>> >> >> + MT9M114_720P,
>> >> >> +};
>> >> >
>> >> > This is the part I don't like. Instead of hardcoding 4 different
>> >> > resolutions and using large register address/value tables, you should
>> >> > compute the register values from the image size requested by the user.
>> >>
>> >> In fact we get this table with the Aptina development tool. So we only
>> >> support fixed resolutions. If we compute each register value, it only
>> >> makes the code more complex.
>> >
>> > But it also makes the code more useful, as the user won't be limited to
>> > the 4 resolutions above.
>>
>> The problem is Aptina datasheet doesn't tell us how to calculate these
>> values. We only have some register presets.
>
> Have you tried requesting the information from Aptina ?
No, there is only a datasheet on its website. I refer to register
definition from Andrew Chew on this website :
http://git.chromium.org/gitweb/?p=chromiumos/third_party/kernel-next.git;a=blob;f=drivers/media/video/mt9m114.c;h=a5d2724005e7863607ffe204eefabfb0fad4da46.
Even if we have any NDA docs, we can't use it in open source code.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
