On Mon, 11 Mar 2013 19:25:10 +0200 Antti Palosaari <crope@xxxxxx> wrote: > drivers/media/usb/dvb-usb/m920x.c: In function ‘m920x_probe’: > drivers/media/usb/dvb-usb/m920x.c:91:6: warning: ‘ret’ may be used uninitialized in this function [-Wuninitialized] > drivers/media/usb/dvb-usb/m920x.c:70:6: note: ‘ret’ was declared here > > Signed-off-by: Antti Palosaari <crope@xxxxxx> Acked-by: Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx> And thanks. BTW Antti, there was another patch for this warning: http://thread.gmane.org/gmane.linux.kernel/1450717 but your change is easier to validate. > --- > drivers/media/usb/dvb-usb/m920x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/dvb-usb/m920x.c b/drivers/media/usb/dvb-usb/m920x.c > index 92afeb2..f5e4654 100644 > --- a/drivers/media/usb/dvb-usb/m920x.c > +++ b/drivers/media/usb/dvb-usb/m920x.c > @@ -67,7 +67,7 @@ static inline int m920x_write(struct usb_device *udev, u8 request, > static inline int m920x_write_seq(struct usb_device *udev, u8 request, > struct m920x_inits *seq) > { > - int ret; > + int ret = 0; > while (seq->address) { > ret = m920x_write(udev, request, seq->data, seq->address); > if (ret != 0) > -- > 1.7.11.7 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html