On Tue, Feb 5, 2013 at 12:03 PM, Inki Dae <inki.dae@xxxxxxxxxxx> wrote: > 2013/2/4 Sachin Kamat <sachin.kamat@xxxxxxxxxx>: >> On 1 February 2013 18:28, Inki Dae <daeinki@xxxxxxxxx> wrote: >>> >>> >>> >>> >>> 2013. 2. 1. 오후 8:52 Inki Dae <inki.dae@xxxxxxxxxxx> 작성: >>> >>>> >>>> >>>>> -----Original Message----- >>>>> From: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media- >>>>> owner@xxxxxxxxxxxxxxx] On Behalf Of Sachin Kamat >>>>> Sent: Friday, February 01, 2013 8:40 PM >>>>> To: Inki Dae >>>>> Cc: Sylwester Nawrocki; Kukjin Kim; Sylwester Nawrocki; linux- >>>>> media@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; devicetree- >>>>> discuss@xxxxxxxxxxxxxxxx; patches@xxxxxxxxxx >>>>> Subject: Re: [PATCH 2/2] drm/exynos: Add device tree based discovery >>>>> support for G2D >>>>> >>>>> On 1 February 2013 17:02, Inki Dae <inki.dae@xxxxxxxxxxx> wrote: >>>>>> >>>>>> How about using like below? >>>>>> Compatible = ""samsung,exynos4x12-fimg-2d" /* for Exynos4212, >>>>>> Exynos4412 */ >>>>>> It looks odd to use "samsung,exynos4212-fimg-2d" saying that this ip is >>>>> for >>>>>> exynos4212 and exynos4412. >>>>> >>>>> AFAIK, compatible strings are not supposed to have any wildcard >>>> characters. >>>>> Compatible string should suggest the first SoC that contained this IP. >>>>> Hence IMO 4212 is OK. >>>>> >>> >>> Oops, one more thing. AFAIK Exynos4210 also has fimg-2d ip. In this case, we should use "samsung,exynos4210-fimg-2d" as comparible string and add it to exynos4210.dtsi? >> >> Exynos4210 has same g2d IP (v3.0) as C110 or V210; so the same >> comptible string will be used for this one too. >> >>> And please check if exynos4212 and 4412 SoCs have same fimg-2d ip. If it's different, we might need to add ip version property or compatible string to each dtsi file to identify the ip version. >> >> AFAIK, they both have the same IP (v4.1). >> > > Ok, let's use the below, > > For exynos4210 SoC, > compatible = "samsung,exynos4210-g2d" > > For exynos4x12 SoCs, > compatible = "samsung,exynos4212-g2d" Even though 4212 is exist, I can't see 4212 board support at mainline. so I prefer exynos4412-g2d instead of 4212-g2d. > > For exynos5250, 5410 (In case of Exynos5440, I'm not sure that the SoC > has same ip) > compatible = "samsung,exynos5250-g2d" Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > To other guys, > The device tree is used by not only v4l2 side but also drm side so we > should reach an arrangement. So please give me ack if you agree to my > opinion. Otherwise please, give me your opinions. > > Thanks, > Inki Dae > > >>> >>> Sorry but give me your opinions. >>> >>> Thanks, >>> Inki Dae >>> >>> >>>> >>>> Got it. Please post it again. >>>> >>>>> >>>>> -- >>>>> With warm regards, >>>>> Sachin >>>>> -- >>>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in >>>>> the body of a message to majordomo@xxxxxxxxxxxxxxx >>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>> >>>> _______________________________________________ >>>> dri-devel mailing list >>>> dri-devel@xxxxxxxxxxxxxxxxxxxxx >>>> http://lists.freedesktop.org/mailman/listinfo/dri-devel >> >> >> >> -- >> With warm regards, >> Sachin > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
