Hi, Jonathan
As you know, we are working on adding B_DMA_SG support on soc_camera mode.
We found there is some code we can't understand in irq handler:
>>>>>>
if (handled == IRQ_HANDLED) {
set_bit(CF_DMA_ACTIVE, &cam->flags);
if (cam->buffer_mode == B_DMA_sg)
mcam_ctlr_stop(cam);
}
<<<<<<
The question is why we need stop ccic in irq handler when buffer mode is B_DMA_sg?
>>>
if (cam->buffer_mode == B_DMA_sg)
mcam_ctlr_stop(cam);
<<<
Currently we tested B_DMA_sg mode on our platform, and this buffer mode can work only if we comment these 2 lines.
Could you please help us take a look if you have time?
Thank you very much for your help! :)
Thanks
Albert Wang
86-21-61092656
>-----Original Message-----
>From: Albert Wang
>Sent: Wednesday, 19 December, 2012 04:48
>To: 'Jonathan Corbet'
>Cc: g.liakhovetski@xxxxxx; linux-media@xxxxxxxxxxxxxxx; Libin Yang
>Subject: RE: [PATCH V3 10/15] [media] marvell-ccic: split mcam-core into 2 parts for
>soc_camera support
>
>Hi, Jonathan
>
>
>>-----Original Message-----
>>From: Jonathan Corbet [mailto:corbet@xxxxxxx]
>>Sent: Wednesday, 19 December, 2012 03:15
>>To: Albert Wang
>>Cc: g.liakhovetski@xxxxxx; linux-media@xxxxxxxxxxxxxxx; Libin Yang
>>Subject: Re: [PATCH V3 10/15] [media] marvell-ccic: split mcam-core into 2 parts for
>>soc_camera support
>>
>>On Mon, 17 Dec 2012 19:04:26 -0800
>>Albert Wang <twang13@xxxxxxxxxxx> wrote:
>>
>>> [Albert Wang] So if we add B_DMA_SG and B_VMALLOC support and OLPC XO 1.0
>>support in soc_camera mode.
>>> Then we can just remove the original mode and only support soc_camera mode in
>>marvell-ccic?
>>
>>That is the idea, yes. Unless there is some real value to supporting both
>>modes (that I've not seen), I think it's far better to support just one of
>>them. Trying to support duplicated modes just leads to pain in the long
>>run, in my experience.
>>
>[Albert Wang] OK, we will update and submit the remained patches except for the 3
>patches related with soc_camera support as the first part.
>Then we will submit the soc_camera support patches after we rework the patches and add
>B_DMA_SG and B_VMALLOC support and OLPC XO 1.0 support.
>
>>I can offer to *try* to find time to help with XO 1.0 testing when the
>>time comes.
>>
>[Albert Wang] Thank you very much! We were worried about how to get the OLPC XO 1.0
>HW. That would be a great help! :)
>
>>Thanks,
>>
>>jon
>
>
>Thanks
>Albert Wang
>86-21-61092656
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
