Re: tda8290 regression fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2012-11-15 21:43, Anders Thomson wrote:
On 2012-10-01 18:56, Anders Thomson wrote:
>  On 2012-09-23 23:06, Anders Thomson wrote:
>  >   Awfully sorry about this. After having had the familty sit in and check
>  >   the differences,
>  >   I must say that the patch does not fix the issue. This time around I
>  >   have x11grabs with
>  >   ffmpeg to show if you want.
>  >
>  >   I'll be away from the card until the end of the coming week. Then, I'll
>  >   bring out the multimeter...
>  >
>  >
>  So, I got the multimeter working over the weekend and pretty much no
>  results there. :-(
>  I tested vanilla 3.5.3, w/ my patch, w/ your "tuner" patch. All three
>  gave a (DC) reading of 0 to 30 mV (yes milli-). Given that the wiki page
>  you referred to spoke of a few volts, I guess this is just noise. Coming
>  to think of it, shouldn't any signal amplification done work on HF, so
>  I'd have to measure the AC on the carrier freq or something? This
>  multimeter is useless in the MHz range...
>
>  While at it, I created these 20 sec snippets:
>  http://pickup.famthomson.se/output-vanilla.avi
>  vanilla 3.5.3
>
>  http://pickup.famthomson.se/output-test3.avi
>  This patch:
>     # cat /TV_TEST3.diff
>  diff --git a/drivers/media/video/saa7134/saa7134-cards.c
>  b/drivers/media/video/saa7134/saa7134-cards.c
>  index bc08f1d..98b482e 100644
>  --- a/drivers/media/video/saa7134/saa7134-cards.c
>  +++ b/drivers/media/video/saa7134/saa7134-cards.c
>  @@ -3291,7 +3291,7 @@ struct saa7134_board saa7134_boards[] = {
>                    .radio_type     = UNSET,
>                    .tuner_addr     = ADDR_UNSET,
>                    .radio_addr     = ADDR_UNSET,
>  -               .tuner_config   = 1,
>  +               .tuner_config   = 0,
>                    .mpeg           = SAA7134_MPEG_DVB,
>                    .gpiomask       = 0x000200000,
>                    .inputs         = {{
>
>  http://pickup.famthomson.se/output-card.avi
>  This patch:
>     # cat /TV_CARD.diff
>  diff --git a/drivers/media/common/tuners/tda8290.c
>  b/drivers/media/common/tuners/tda8290.c
>  index 064d14c..498cc7b 100644
>  --- a/drivers/media/common/tuners/tda8290.c
>  +++ b/drivers/media/common/tuners/tda8290.c
>  @@ -635,7 +635,11 @@ static int tda829x_find_tuner(struct dvb_frontend *fe)
>
>                    dvb_attach(tda827x_attach, fe, priv->tda827x_addr,
>                               priv->i2c_props.adap,&priv->cfg);
>  +               tuner_info("ANDERS: setting switch_addr. was 0x%02x, new
>  0x%02x\n",priv->cfg.switch_addr,priv->i2c_props.addr);
>                    priv->cfg.switch_addr = priv->i2c_props.addr;
>  +               priv->cfg.switch_addr = 0xc2 / 2;
>  +               tuner_info("ANDERS: new 0x%02x\n",priv->cfg.switch_addr);
>  +
>            }
>            if (fe->ops.tuner_ops.init)
>                    fe->ops.tuner_ops.init(fe);
>
>
>  Would looking again at the specifics on the 2.6.25->26 transition be of
>  any help? I expect some pain to go to such old kernel, but if I can add
>  some printks somewhere, maybe that could help?
>
>  Cheers,
>  -Anders
>
Hi Mauro,

Picking up this thread again. Did you have chance to look into this?

/Anders
Hi Mauro,

Any chance we can make progress on this one? As indicated, the patches you've proposed do not work. I have no idea why mine does though....

/Anders
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux