Re: tda8290 regression fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2012-09-23 19:54, Anders Thomson wrote:
>  diff --git a/drivers/media/pci/saa7134/saa7134-cards.c b/drivers/media/pci/saa7134/saa7134-cards.c
>  index bc08f1d..98b482e 100644
>  --- a/drivers/media/pci/saa7134/saa7134-cards.c
>  +++ b/drivers/media/pci/saa7134/saa7134-cards.c
>  @@ -3288,13 +3288,13 @@ struct saa7134_board saa7134_boards[] = {
>    		.name           = "Pinnacle PCTV 310i",
>    		.audio_clock    = 0x00187de7,
>    		.tuner_type     = TUNER_PHILIPS_TDA8290,
>    		.radio_type     = UNSET,
>    		.tuner_addr     = ADDR_UNSET,
>    		.radio_addr     = ADDR_UNSET,
>  -		.tuner_config   = 1,
>  +		.tuner_config   = 0,
>    		.mpeg           = SAA7134_MPEG_DVB,
>    		.gpiomask       = 0x000200000,
>    		.inputs         = {{
>    			.name = name_tv,
>    			.vmux = 4,
>    			.amux = TV,
>
>
>  Please test if the above patch fixes the issue you're suffering[1]. If so, then
>  we'll need to add a modprobe parameter to allow disabling LNA for saa7134 devices
>  with LNA.
>
>  [1] Note: the above is not the fix, as some users of this board may be using the
>  original antenna, and changing tuner_config will break things for them; the right
>  fix is likely to allow controlling the LNA via userspace.
Tried that patch on 3.5.3. No improvement, unfortunately.
I have to retract that. It turns out that there is some strange interaction
between the cabletv box and the card. When I rebooted into 'my' patch
I still got the noisy signal. I then power cycled the cabletv box, and voila,
I got a good signal on my own patch. Wondering what I had actually tested
with your patch, I tested it again, and indeed it works!

So, 1) you're on to something, that's for sure, and 2) there is _something_ in
the cabletv box which can make all this fall into a bad state too.

Cheers,
/Anders




--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux