Em Thu, 08 Nov 2012 20:03:47 +0200 Frank Schäfer <fschaefer.oss@xxxxxxxxxxxxxx> escreveu: > Am 30.10.2012 19:18, schrieb Frank Schäfer: > > Am 30.10.2012 06:06, schrieb Mauro Carvalho Chehab: > > > > <snip> > >> Did a git bisect. The last patch where the bug doesn't occur is this > >> changeset: > >> em28xx: add module parameter for selection of the preferred USB transfer type > >> > >> That means that this changeset broke it: > >> > >> em28xx: use common urb data copying function for vbi and non-vbi devices > > Ok, thanks. > > That means we are VERY close... > > > > I think this is the only change that could cause the trouble: > >> @@ -599,6 +491,7 @@ static inline int em28xx_urb_data_copy_vbi(struct em28xx *dev, struct urb *urb) > >> len = actual_length - 4; > >> } else if (p[0] == 0x22 && p[1] == 0x5a) { > >> /* start video */ > >> + dev->capture_type = 1; > >> p += 4; > >> len = actual_length - 4; > >> } else { > > Could you try again with this line commented out ? (em28xx-video.c, line > > 494 in the patched file). > > usb_debug=1 would be usefull, too. > > > >> I didn't test them with my Silvercrest webcam yet. > > I re-tested 5 minutes ago with this device and it works fine. > > Btw, which frame rates do you get ? ;) > > > > Regards, > > Frank > > Today I had the chance to test these patches with a Hauppauge HVR-930c. > Couldn't test analog TV (not supported yet), but DVB works fine, too. While I would love to have it, analog support for HVR-930C would likely not happen. I don't know anyone working on it. There are two issues there: 1) it uses an unsupported micronas analog demod chipset; 2) drx-k requrires some changes to tune on analog mode. As usual, patches for it are of course very welcome. > > So patches 1 to 21 have been tested now and do at least not cause any > regressions. > > I would like to drop the last two patches (22+23) of this series, because > - they are actually not related to USB bulk transfers > - patch 22 needs to be fixed for analog+vbi (will get an analog device > for testing next week) > - I'm working on further improvements/changes in this area (including > em25xx support) > So I will better come up with a separate patch series later. OK. > Will send a v2 of this patch series soon. > > Regards, > Frank > > Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html