Em Tue, 30 Oct 2012 09:08:15 -0400 Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx> escreveu: > On Tue, Oct 30, 2012 at 12:06 AM, Mauro Carvalho Chehab > <mchehab@xxxxxxxxxx> wrote: > > Did a git bisect. The last patch where the bug doesn't occur is this > > changeset: > > em28xx: add module parameter for selection of the preferred USB transfer type > > > > That means that this changeset broke it: > > > > em28xx: use common urb data copying function for vbi and non-vbi devices > > Oh good, when I saw the subject line for that patch, I got worried. > Looking at the patch, it seems like he just calls the VBI version for > both cases assuming the VBI version is a complete superset of the > non-VBI version, which it is clearly not. > > That whole patch should just be reverted. I didn't apply Frank's patch yet. So, no need to revert ;) Also, the test is still incomplete, as I didn't check if the existing webcam support is still working. I also didn't review each individual changes (although, on a quick glance, except for those two final patches, nothing bad popped-up). I'll likely finish testing and will review it only after my return back from ELCE. > If he's going to spend the > time to refactor the code to allow the VBI version to be used for both > then fine, but blindly calling the VBI version without making real > code changes is *NOT* going to work. Yes. > Frank, good job in naming your patch - it made me scream "WAIT!" when > I saw it. Bad job for blindly submitting a code change without any > idea whether it actually worked. ;-) > > I know developers have the tendency to look at code and say "oh, > that's ugly, I should change that." However it's more important that > it actually work than it be pretty. > > Devin > -- Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
