Re: [PATCH 00/23] em28xx: add support fur USB bulk transfers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 28.10.2012 16:08, schrieb Mauro Carvalho Chehab:
> Em 28-10-2012 11:00, Frank Schäfer escreveu:
>> Am 21.10.2012 19:52, schrieb Frank Schäfer:
>>> This patch series adds support for USB bulk transfers to the em28xx
>>> driver.
>>
>> Mauro,
>> I sent this patches to you because you are listed as the maintainer and
>> it would be nice to get at least a reply from you.
>
> Yeah, they're on my queue. I'll reply about patch specifics when I get
> there.
> There are still some other patches that arrived before yours.
>
> Whenever I touch them, patchwork will notify you.

Ok, thanks, that's all I wanted to know.

>
>> What's you plan with these patches ?
>
> As you asked for tests with VBI, it will require me to have some spare
> time
> for testing, in a timeframe where I could get some TV program with VBI.
> Only a few news programs on one or two channels here transmit VBI.

Maybe my warnings were a bit too loud ;) I just wanted to be honest
about untested paths.
The changes in frame processing are not specific to analog/DVB
interlaced/progressive or VBI/non-VBI.
As they have been tested carefully with an analog/progressive/non-VBI
device, they should work for others, too.
I'm only concerned about further existing bugs that didin't show up as
long as isoc is used only...
OTOH, we keep on using isoc by default, so noone will notice them until
explicitly enabling bulk.

IMO, the most critical change is patch 20. You should review the changes
regarding the endpoint mapping logic carefully.
Maybe you get some ideas how we could improve this in the future without
breaking backwards compatibility.


>
> So, it may take a little for them to get into. If I can't handle today,
> I will likely be able to do it only after my return back from ELCE.

No need to hurry.
For me important to know is, that a) it makes sense to continue working
on this driver and that b) I can base the next patches on this series.

Regards,
Frank

>
>> ATM I'm not sure if it makes sense to continue working (and spending a
>> good amount of my free time) on further changes/extensions.
>> The em25xx stuff you want to have in this driver requires lots of much
>> more complicating changes and without any assistance/coorporation from
>> the linux-media list, it will be impossible to get them upstream.
>>
>> Regards,
>> Frank
>>
>>
>
> Regards,
> Mauro

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux