Hi Laurent,
Thanks for the review!
Laurent Pinchart wrote:
Hi Sakari,
Thanks for the patch.
On Thursday 27 September 2012 00:50:35 Sakari Ailus wrote:
The OMAP 3630 has configuration how the ISP CSI-2 PHY pins are connected to
the actual CSI-2 receivers outside the ISP itself. Allow changing this
configuration from the ISP driver.
Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx>
Just one small comment below, otherwise
Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
---
arch/arm/mach-omap2/control.c | 86 +++++++++++++++++++++++++
arch/arm/mach-omap2/control.h | 15 +++++
arch/arm/mach-omap2/include/mach/control.h | 13 ++++
3 files changed, 114 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/mach-omap2/include/mach/control.h
diff --git a/arch/arm/mach-omap2/control.c b/arch/arm/mach-omap2/control.c
index 3223b81..11bb900 100644
--- a/arch/arm/mach-omap2/control.c
+++ b/arch/arm/mach-omap2/control.c
...
+ cam_phy_ctrl |= mode << shift;
+
+ omap_ctrl_writel(cam_phy_ctrl,
+ OMAP3630_CONTROL_CAMERA_PHY_CTRL);
This can fit on one line.
I'll fix that for the next version. I noticed there were a few too long
lines, too; I've broken them up where it makes sense, and removed a
useless break statement.
Cheers,
--
Sakari Ailus
sakari.ailus@xxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
