Em Thu, 27 Sep 2012 14:41:25 -0300
Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> escreveu:
> Em Fri, 17 Aug 2012 04:35:08 +0300
> Antti Palosaari <crope@xxxxxx> escreveu:
>
> > Make LNA run-time switching possible for PCTV nanoStick T2 290e!
> >
> > Signed-off-by: Antti Palosaari <crope@xxxxxx>
> > ---
> > drivers/media/usb/em28xx/em28xx-dvb.c | 40 ++++++++++++++++++++++++++++++-----
> > 1 file changed, 35 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c
> > index 34c5ea9..75f907a 100644
> > --- a/drivers/media/usb/em28xx/em28xx-dvb.c
> > +++ b/drivers/media/usb/em28xx/em28xx-dvb.c
> > @@ -81,6 +81,7 @@ struct em28xx_dvb {
> > int (*gate_ctrl)(struct dvb_frontend *, int);
> > struct semaphore pll_mutex;
> > bool dont_attach_fe1;
> > + int gpio;
>
> Please, don't call it simply as "gpio". There are 12 GPIO pins at em28xx devices,
> used by tuners, demods, IR's, LED's, etc. Instead, you should associate it
> with its function. I would call it as "lna_gpio" (or something like that).
Due to this changeset, I had to remove those two patches from the list of applied ones.
Aug,17 2012: cxd2820r: use static GPIO config when GPIOLIB is undefined 0006-cxd2820r-use-static-GPIO-config-when-GPIOLIB-is-unde.patch Antti Palosaari <crope@xxxxxx>
Sep,20 2012: em28xx: do not set PCTV 290e LNA handler if fe attach fail 0019-em28xx-do-not-set-PCTV-290e-LNA-handler-if-fe-attach.patch Antti Palosaari <crope@xxxxxx>
Please, re-submit them when you replace "gpio" by something meaningful.
Thanks!
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
