On 23 August 2012 15:08, Ezequiel Garcia <elezegarcia@xxxxxxxxx> wrote: > queue_init() is always called by v4l2_m2m_ctx_init(), which allocates > a context struct v4l2_m2m_ctx with kzalloc. > Therefore, there is no need to clear vb2_queue src/dst structs. > > Cc: Javier Martin <javier.martin@xxxxxxxxxxxxxxxxx> > Signed-off-by: Ezequiel Garcia <elezegarcia@xxxxxxxxx> > --- > drivers/media/platform/coda.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c > index 6908514..3ea822f 100644 > --- a/drivers/media/platform/coda.c > +++ b/drivers/media/platform/coda.c > @@ -1249,7 +1249,6 @@ static int coda_queue_init(void *priv, struct vb2_queue *src_vq, > struct coda_ctx *ctx = priv; > int ret; > > - memset(src_vq, 0, sizeof(*src_vq)); > src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT; > src_vq->io_modes = VB2_MMAP; > src_vq->drv_priv = ctx; > @@ -1261,7 +1260,6 @@ static int coda_queue_init(void *priv, struct vb2_queue *src_vq, > if (ret) > return ret; > > - memset(dst_vq, 0, sizeof(*dst_vq)); > dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; > dst_vq->io_modes = VB2_MMAP; > dst_vq->drv_priv = ctx; > -- > 1.7.8.6 > Acked-By: Javier Martin <javier.martin@xxxxxxxxxxxxxxxxx> -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
