On 08/05/2012 09:16 PM, Mauro Carvalho Chehab wrote:
There's just one driver using fe_ioctl_override(), and it can be replaced at tuner_attach call. This callback is evil, as only DVBv3 calls are handled. Removing it is also a nice cleanup, as about 90 lines of code are removed. Get rid of it!
I totally agree that! Only mxl111sf.c uses it and it was overriding signal strength meter which could be overridden by simply replacing fe default demod callback by one from tuner.
Actually it was very near I removed support for it from dvb-usb-v2 totally but still decided to leave as I converted mxl111sf driver. You likely saw my comments to avoid using it in dvb_usb.h :)
Mauro Carvalho Chehab (2): [media] dvb core: remove support for post FE legacy ioctl intercept [media] dvb: get rid of fe_ioctl_override callback drivers/media/dvb/dvb-core/dvb_frontend.c | 20 +---------------- drivers/media/dvb/dvb-core/dvbdev.h | 26 ---------------------- drivers/media/dvb/dvb-usb-v2/dvb_usb.h | 3 --- drivers/media/dvb/dvb-usb-v2/dvb_usb_core.c | 2 -- drivers/media/dvb/dvb-usb-v2/mxl111sf.c | 34 +---------------------------- drivers/media/dvb/dvb-usb/dvb-usb-dvb.c | 1 - drivers/media/dvb/dvb-usb/dvb-usb.h | 2 -- drivers/media/video/cx23885/cx23885-dvb.c | 3 +-- drivers/media/video/cx88/cx88-dvb.c | 2 +- drivers/media/video/saa7134/saa7134-dvb.c | 2 +- drivers/media/video/videobuf-dvb.c | 11 +++------- include/media/videobuf-dvb.h | 4 +--- 12 files changed, 9 insertions(+), 101 deletions(-)
regards Antti -- http://palosaari.fi/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
