Re: [PATCH v4 4/5] media: gscaler: Add m2m functionality for the G-Scaler driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue 31 July 2012 14:12:32 Shaik Ameer Basha wrote:
> From: Sungchun Kang <sungchun.kang@xxxxxxxxxxx>
> 
> This patch adds the memory to memory (m2m) interface functionality
> for the G-Scaler driver.
> 
> Signed-off-by: Hynwoong Kim <khw0178.kim@xxxxxxxxxxx>
> Signed-off-by: Sungchun Kang <sungchun.kang@xxxxxxxxxxx>
> Signed-off-by: Shaik Ameer Basha <shaik.ameer@xxxxxxxxxxx>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> ---
>  drivers/media/video/exynos-gsc/gsc-m2m.c |  772 ++++++++++++++++++++++++++++++
>  1 files changed, 772 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/media/video/exynos-gsc/gsc-m2m.c
> 
> diff --git a/drivers/media/video/exynos-gsc/gsc-m2m.c b/drivers/media/video/exynos-gsc/gsc-m2m.c
> new file mode 100644
> index 0000000..d7ecdb8
> --- /dev/null
> +++ b/drivers/media/video/exynos-gsc/gsc-m2m.c


> +static int gsc_m2m_querycap(struct file *file, void *fh,
> +			   struct v4l2_capability *cap)
> +{
> +	struct gsc_ctx *ctx = fh_to_ctx(fh);
> +	struct gsc_dev *gsc = ctx->gsc_dev;
> +
> +	strlcpy(cap->driver, gsc->pdev->name, sizeof(cap->driver));
> +	strlcpy(cap->card, gsc->pdev->name, sizeof(cap->card));
> +	strlcpy(cap->bus_info, "platform", sizeof(cap->bus_info));
> +	cap->device_caps = V4L2_CAP_STREAMING |
> +				V4L2_CAP_VIDEO_CAPTURE_MPLANE |
> +				V4L2_CAP_VIDEO_OUTPUT_MPLANE;

Yesterday the new V4L2_CAP_M2M_PLANE was added. You should add this
capability here. It is up to you to decide whether to remove the
CAPTURE_MPLANE and OUTPUT_MPLANE caps at the same time, or leave them for
a bit until any applications have had the chance to use the new M2M capability.

Combining the capture and output caps caused problems since apps would misdetect
this as a normal capture device instead of an M2M device. It's only for a
transition time that all three caps are allowed.

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux