Hi Laurent,
On Tue, Jul 31, 2012 at 01:38:41PM +0200, Laurent Pinchart wrote:
> Thanks for the patch.
Thanks for the comments!
> On Tuesday 31 July 2012 01:16:00 Sakari Ailus wrote:
> > v4l2_subdev_enum_mbus_code() enumerates over supported media bus formats on
> > a pad.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx>
> > ---
> > src/v4l2subdev.c | 23 +++++++++++++++++++++++
> > src/v4l2subdev.h | 14 ++++++++++++++
> > 2 files changed, 37 insertions(+), 0 deletions(-)
> >
> > diff --git a/src/v4l2subdev.c b/src/v4l2subdev.c
> > index d60bd7e..6b6df0a 100644
> > --- a/src/v4l2subdev.c
> > +++ b/src/v4l2subdev.c
> > @@ -58,6 +58,29 @@ void v4l2_subdev_close(struct media_entity *entity)
> > entity->fd = -1;
> > }
> >
> > +int v4l2_subdev_enum_mbus_code(struct media_entity *entity,
> > + uint32_t *code, uint32_t pad, uint32_t index)
>
> I would use unsigned int for the pad and index arguments to match the other
> functions. We could then fix all of them in one go to use stdint types to
> match the kernel API types.
I'm fine with that.
> > +{
> > + struct v4l2_subdev_mbus_code_enum c;
> > + int ret;
> > +
> > + ret = v4l2_subdev_open(entity);
> > + if (ret < 0)
> > + return ret;
> > +
> > + memset(&c, 0, sizeof(c));
> > + c.pad = pad;
> > + c.index = index;
> > +
> > + ret = ioctl(entity->fd, VIDIOC_SUBDEV_ENUM_MBUS_CODE, &c);
> > + if (ret < 0)
> > + return -errno;
> > +
> > + *code = c.code;
> > +
> > + return 0;
> > +}
>
> What about a higher-level API that would enumerate all formats and return a
> list/array ?
The information could be stored to media entities. We could add a V4L2
subdev pointer to media entities, and have the information stored there the
first time this function is called. How about that?
On source pads the pixel code is obviously possibly dependent on the pixel
code on the sink pad so I need to store mappings from sink pad pixel code to
a list of source pad pixel code, but can it have other dependencies? None
come to mind right now, though.
Cheers,
--
Sakari Ailus
e-mail: sakari.ailus@xxxxxx jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
