On 18 July 2012 14:12, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote: > Am Mittwoch, den 18.07.2012, 11:26 +0200 schrieb javier Martin: >> On 18 July 2012 11:22, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote: >> > Hi Javier, >> > >> > Am Mittwoch, den 18.07.2012, 11:01 +0200 schrieb javier Martin: >> >> On 18 July 2012 10:35, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote: >> >> > Hi Javier, >> >> > >> >> > Am Mittwoch, den 18.07.2012, 09:12 +0200 schrieb javier Martin: >> >> > [...] >> >> >> > I see there is a comment about the expected register setting not working >> >> >> > for CODA_REG_BIT_STREAM_CTRL in start_streaming(). Could this be >> >> >> > related? >> >> >> >> >> >> I don't think so. This means that the following line: >> >> >> >> >> >> coda_write(dev, (3 << 3), CODA_REG_BIT_STREAM_CTRL); >> >> >> >> >> >> should be: >> >> >> >> >> >> coda_write(dev, (CODADX6_STREAM_BUF_PIC_RESET | >> >> >> CODADX6_STREAM_BUF_PIC_FLUSH), CODA_REG_BIT_STREAM_CTRL); >> >> >> >> >> >> But the latter does not work. >> >> > >> >> > Looks to me like (3 << 3) == (CODA7_STREAM_BUF_PIC_RESET | >> >> > CODA7_STREAM_BUF_PIC_FLUSH) could be the explanation. >> >> >> >> You mean "!=", don't you? >> > >> > I mean "==". coda.h contains: >> > >> > #define CODA7_STREAM_BUF_PIC_RESET (1 << 4) >> > #define CODA7_STREAM_BUF_PIC_FLUSH (1 << 3) >> > >> > So maybe those are the correct bits for i.MX27 with the 2.2.5 firmware. >> > If that is the case, you could do s/CODA7_STREAM_BUF_/CODA_STREAM_BUF_/ >> > and drop the incorrect CODADX6_STREAM_BUF_ defines. >> >> Sorry, I didn't catch the 'CODA7' prefix in your defines. >> OK then, I'll do s/CODA7_STREAM_BUF_/CODA_STREAM_BUF_/ and remove the >> comment too. > > Hold on, I just read that there should be a ENC_DYN_BUFALLOC_EN bit > ((1 << 5) on i.MX53, (1 << 4) on i.MX27) - so maybe the #defines are > right after all, just that bit needs to be set for the dynamic buffer > handling to work. Thanks Philipp, I'll take a look at it. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
