Hi Javier, Am Mittwoch, den 18.07.2012, 09:12 +0200 schrieb javier Martin: [...] > > I see there is a comment about the expected register setting not working > > for CODA_REG_BIT_STREAM_CTRL in start_streaming(). Could this be > > related? > > I don't think so. This means that the following line: > > coda_write(dev, (3 << 3), CODA_REG_BIT_STREAM_CTRL); > > should be: > > coda_write(dev, (CODADX6_STREAM_BUF_PIC_RESET | > CODADX6_STREAM_BUF_PIC_FLUSH), CODA_REG_BIT_STREAM_CTRL); > > But the latter does not work. Looks to me like (3 << 3) == (CODA7_STREAM_BUF_PIC_RESET | CODA7_STREAM_BUF_PIC_FLUSH) could be the explanation. Maybe the documentation about CODADX6_STREAM_BUF_PIC_RESET | CODADX6_STREAM_BUF_PIC_FLUSH was outdated? > > Also, I've missed two problems with platform device removal and module > > autoloading before, see below. > > Fine. [...] > I will send a new v4 with the 'platform' and 'bytesused' issues fixed. > Regarding your i.MX53 problems I suppose they should be addressed > conditionally in a patch on top of this one where i.MX53 support is > added too. > What do you think? Agreed. After fixing the issues in vidioc_try_fmt, MODULE_DEVICE_TABLE, and coda_remove, feel free to add a Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
