On Mon, Jul 09, 2012 at 09:46:03AM +0200, javier Martin wrote: > On 9 July 2012 09:43, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > > On Mon, Jul 09, 2012 at 09:37:25AM +0200, javier Martin wrote: > >> On 9 July 2012 09:28, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > >> > On Fri, Jul 06, 2012 at 12:56:02PM +0200, Javier Martin wrote: > >> >> This driver wasn't converted to the new clock changes > >> >> (clk_prepare_enable/clk_disable_unprepare). Also naming > >> >> of emma-prp related clocks for the i.MX27 was not correct. > >> >> --- > >> >> Enable clocks only for i.MX27. > >> >> > >> > > >> > Indeed, > >> > > >> >> > >> >> - pcdev->clk_csi = clk_get(&pdev->dev, NULL); > >> >> - if (IS_ERR(pcdev->clk_csi)) { > >> >> - dev_err(&pdev->dev, "Could not get csi clock\n"); > >> >> - err = PTR_ERR(pcdev->clk_csi); > >> >> - goto exit_kfree; > >> >> + if (cpu_is_mx27()) { > >> >> + pcdev->clk_csi = devm_clk_get(&pdev->dev, "ahb"); > >> >> + if (IS_ERR(pcdev->clk_csi)) { > >> >> + dev_err(&pdev->dev, "Could not get csi clock\n"); > >> >> + err = PTR_ERR(pcdev->clk_csi); > >> >> + goto exit_kfree; > >> >> + } > >> > > >> > but why? Now the i.MX25 won't get a clock anymore. > >> > >> What are the clocks needed by i.MX25? csi only? > >> > >> By the way, is anybody using this driver with i.MX25? > > > > It seems Baruch (added to Cc) has used it on an i.MX25. > > Baruch, > could you tell us what are the clocks needed by i.MX25? I just had a look and the i.MX25 it needs three clocks: ipg, ahb and peripheral clock. So this is broken anyway and should probably be fixed seperately, that is: - provide dummy clocks for the csi clocks on i.MX27 - clk_get ipg, ahb and peripheral clocks on all SoCs - clk_get emma clocks on i.MX27 only As said, this is a separate topic, so your original patch should be fine for now. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html