On Fri, Jul 06, 2012 at 12:56:02PM +0200, Javier Martin wrote: > This driver wasn't converted to the new clock changes > (clk_prepare_enable/clk_disable_unprepare). Also naming > of emma-prp related clocks for the i.MX27 was not correct. > --- > Enable clocks only for i.MX27. > Indeed, > > - pcdev->clk_csi = clk_get(&pdev->dev, NULL); > - if (IS_ERR(pcdev->clk_csi)) { > - dev_err(&pdev->dev, "Could not get csi clock\n"); > - err = PTR_ERR(pcdev->clk_csi); > - goto exit_kfree; > + if (cpu_is_mx27()) { > + pcdev->clk_csi = devm_clk_get(&pdev->dev, "ahb"); > + if (IS_ERR(pcdev->clk_csi)) { > + dev_err(&pdev->dev, "Could not get csi clock\n"); > + err = PTR_ERR(pcdev->clk_csi); > + goto exit_kfree; > + } but why? Now the i.MX25 won't get a clock anymore. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html