[PATCH v2 0/9] struct i2c_algo_bit_data cleanup on several drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mauro,

This patchset cleans the i2c part of some drivers.
This issue was recently reported by Dan Carpenter [1],
and revealed wrong (and harmless) usage of struct i2c_algo_bit_data.

This series consist in two kinds of patches:
 - remove one unused function
 - remove unused field i2c_algo
 - replace struct memcpy with struct assignment

This last change is, in my opinion, a much safer way for struct filling
and (in this case) I'm not aware of any change in functionality.

Also I've dropped i2c_rc cleaning entirely. I'm still working on these
and they are not related to this patchset.

As I don't own any of these devices, I can't test the changes beyond
compilation.

Changes from v1:
 - Drop i2c_rc clean patches
 - Verbose commit messages

Ezequiel Garcia (9):
 cx25821: Replace struct memcpy with struct assignment
 cx231xx: Replace struct memcpy with struct assignment
 cx23885: Replace struct memcpy with struct assignment
 saa7164: Replace struct memcpy with struct assignment
 saa7164: Remove unused saa7164_call_i2c_clients()
 cx25821: Remove useless struct i2c_algo_bit_data
 cx231xx: Remove useless struct i2c_algo_bit_data
 cx23885: Remove useless struct i2c_algo_bit_data
 saa7164: Remove useless struct i2c_algo_bit_data

 drivers/media/video/cx231xx/cx231xx-i2c.c |    8 ++------
 drivers/media/video/cx231xx/cx231xx.h     |    2 --
 drivers/media/video/cx23885/cx23885-i2c.c |   10 ++--------
 drivers/media/video/cx23885/cx23885.h     |    2 --
 drivers/media/video/cx25821/cx25821-i2c.c |   10 ++--------
 drivers/media/video/cx25821/cx25821.h     |    2 --
 drivers/media/video/saa7164/saa7164-i2c.c |   20 ++------------------
 drivers/media/video/saa7164/saa7164.h     |    2 --
 8 files changed, 8 insertions(+), 48 deletions(-)

Thanks,
Ezequiel.

[1] http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/49553
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux