On Mon, Jun 18, 2012 at 06:00:52PM -0300, Ezequiel Garcia wrote: > On Mon, Jun 18, 2012 at 5:56 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Mon, Jun 18, 2012 at 04:23:14PM -0300, Ezequiel Garcia wrote: > >> Hi Mauro, > >> > >> This patchset cleans the i2c part of some drivers. > >> This issue was recently reported by Dan Carpenter [1], > >> and revealed wrong (and harmless) usage of struct i2c_algo_bit. > >> > > > > How is this harmless? We are setting the function pointers to > > something completely bogus. It seems like a bad thing. > > > > You're right, but that wrongly assigned struct algo_bit_data is never > *ever* used, > since it is not registered. > > So, I meant it was harmless in that way, perhaps it wasn't the right term. No no. I didn't realize these files didn't call i2c_add_bus(). Harmless is the right term. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
