Em 25-06-2012 16:42, Ezequiel Garcia escreveu: > Hi Mauro, > > On Mon, Jun 25, 2012 at 4:29 PM, Mauro Carvalho Chehab > <mchehab@xxxxxxxxxx> wrote: >>> diff --git a/drivers/media/video/saa7164/saa7164-i2c.c b/drivers/media/video/saa7164/saa7164-i2c.c >>> index 26148f7..536f7dc 100644 >>> --- a/drivers/media/video/saa7164/saa7164-i2c.c >>> +++ b/drivers/media/video/saa7164/saa7164-i2c.c >>> @@ -123,7 +123,7 @@ int saa7164_i2c_register(struct saa7164_i2c *bus) >>> bus->i2c_algo.data = bus; >>> bus->i2c_adap.algo_data = bus; >>> i2c_set_adapdata(&bus->i2c_adap, bus); >>> - i2c_add_adapter(&bus->i2c_adap); >>> + bus->i2c_rc = i2c_add_adapter(&bus->i2c_adap); >>> >>> bus->i2c_client.adapter = &bus->i2c_adap; >>> >>> >> >> -ENODESCRIPTION. > > Okey. Sorry for that. > >> >> What are you intending with this change? AFAICT, i2c_add_bus_adapter() >> returns 0 on success and a negative value otherwise. Why should it be >> stored at bus->i2c_rc? > > My intention was to give i2c_rc its proper use. > I looked at bttv-i2c.c and cx88-i2c.c and (perhaps wrongly) guessed > the intended use to i2c_rc was to save i2c registration result. > > Without this patch, where is this bus->i2c_rc variable used? > Unless I've missed something, to me there are two options: > - use i2c_rc > - remove it If i2c_rc was never initialized, then just remove it. If it is required, then there's a bug somewhere out there on those drivers. IMHO, if the I2C bus doesn't register, any driver that requires I2C bus should return -ENODEV. It should be noticed that there are a few devices that don't need I2C bus to work: simple video grabber cards that don't have anything on their I2C. There are several of them at bttv, and a few at cx88 and saa7134. Maybe that's the reason why those drivers have a var to indicate if i2c got registered. > > Again sorry for lack of description, I thought it was self-explaining patch. > > If you provide some feedback about proper solution, I can resend the > patch series. Thanks! Mauro > > Thanks, > Ezequiel. > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
