Re: [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em 18-06-2012 16:23, Ezequiel Garcia escreveu:
> Signed-off-by: Ezequiel Garcia <elezegarcia@xxxxxxxxx>
> ---
>   drivers/media/video/saa7164/saa7164-i2c.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/video/saa7164/saa7164-i2c.c b/drivers/media/video/saa7164/saa7164-i2c.c
> index 26148f7..536f7dc 100644
> --- a/drivers/media/video/saa7164/saa7164-i2c.c
> +++ b/drivers/media/video/saa7164/saa7164-i2c.c
> @@ -123,7 +123,7 @@ int saa7164_i2c_register(struct saa7164_i2c *bus)
>   	bus->i2c_algo.data = bus;
>   	bus->i2c_adap.algo_data = bus;
>   	i2c_set_adapdata(&bus->i2c_adap, bus);
> -	i2c_add_adapter(&bus->i2c_adap);
> +	bus->i2c_rc = i2c_add_adapter(&bus->i2c_adap);
>   
>   	bus->i2c_client.adapter = &bus->i2c_adap;
>   
> 

-ENODESCRIPTION.

What are you intending with this change? AFAICT, i2c_add_bus_adapter()
returns 0 on success and a negative value otherwise. Why should it be
stored at bus->i2c_rc?

The same applies to the entire patch series.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux