On Sat, Jun 09, 2012 at 10:05:16AM +0200, Hans Verkuil wrote: > On Wed June 6 2012 09:06:23 Julia Lawall wrote: > > The files drivers/media/video/bt8xx/bttv-audio-hook.c and > > drivers/media/video/tvaudio.c contain a number of occurrences of eg: > > > > mode |= V4L2_TUNER_MODE_LANG1 | V4L2_TUNER_MODE_LANG2; > > > > and > > > > if (mode & V4L2_TUNER_MODE_MONO) > > > > (both from tvaudio.c) > > I would have to analyse this more carefully, but the core issue here is that > these drivers mixup the tuner audio reception bitmask flags (V4L2_TUNER_SUB_*) > and the tuner audio modes (V4L2_TUNER_MODE_*, not a bitmask). This happened > regularly in older drivers, and apparently these two are still not fixed. > > More info is here: > > http://hverkuil.home.xs4all.nl/spec/media.html#vidioc-g-tuner > > I can't just replace one define with another, I would need to look carefully > at the code to see what was intended. I have an old patch on one of my other machines that should fix this in tvaudio.c. I'll try to clean it up. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
