Re: [PATCH] [media] em28xx: Show a warning if the board does not support remote controls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Martin,

On Tue, May 29, 2012 at 7:24 PM, Martin Blumenstingl
<martin.blumenstingl@xxxxxxxxxxxxxx> wrote:
> What would you use as the first (dev) argument for dev_*?
> I simply tried using the USB-device (&dev->udev->dev) there, and I
> think it's less
> descriptive if one removes the driver name and the board number:
> usb 1-1.2: Remote control support is not available for this device.
>
> What do you think about using dev_warn but still including the driver name
> and the board number?

You should use em28xx_warn, or any other em28xx_XXX for em28xx tracing.
This way you'll get all the driver name in your message.

#define em28xx_warn(fmt, arg...) do {\
        printk(KERN_WARNING "%s: "fmt,\
                        dev->name , ##arg); } while (0)

Hope it helps,
Ezequiel.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux