Re: [PATCH] [media] em28xx: Show a warning if the board does not support remote controls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Fabio,

I can use dev_err if you want.

And sorry for sending the patch twice.
I messed up the git send-email command here - sorry for that.

Regards,
Martin

> On Tue, May 29, 2012 at 11:22 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
>> On Tue, May 29, 2012 at 6:08 PM, Martin Blumenstingl
>> <martin.blumenstingl@xxxxxxxxxxxxxx> wrote:
>>> This simply shows a little warning if the board does not have remote
>>> control support. This should make it easier for users to see if they
>>> have misconfigured their system or if the driver simply does not have
>>> rc-support for their card (yet).
>>>
>>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
>>> ---
>>>  drivers/media/video/em28xx/em28xx-input.c |    3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/media/video/em28xx/em28xx-input.c b/drivers/media/video/em28xx/em28xx-input.c
>>> index fce5f76..d94b434 100644
>>> --- a/drivers/media/video/em28xx/em28xx-input.c
>>> +++ b/drivers/media/video/em28xx/em28xx-input.c
>>> @@ -527,6 +527,9 @@ static int em28xx_ir_init(struct em28xx *dev)
>>>
>>>        if (dev->board.ir_codes == NULL) {
>>>                /* No remote control support */
>>> +               printk("No remote control support for em28xx "
>>> +                       "card %s (model %d) available.\n",
>>> +                       dev->name, dev->model);
>>
>> What about using dev_err instead?
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux