On Fri, May 11, 2012 at 2:06 PM, <volokh@xxxxxxxxx> wrote: >> >> One question... shouldn't this changeset be splitted into shorter patches? >> > > Yes, should it. > In next iteration i`ll learn how to do that. As a git newbie I've found very useful to work like this: 1. Always work on a branch that's different from master that way you can always do git-rebase --interactive master and quickly review your commits or even rewrite them. 2. If unsure on changeset, add files interactively to stage area (aka the index) with git-add --patch 3. Once you've commit a few stuff, you can simply turn them into patches with git-format-patch master. This way it's very easy to split a change into patches. And with git rebase it's very easy to review and clean commits, to get a cleaner set of patches to keep maintainers happy. Just my two cents, Hope it helps, Ezequiel. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html