On 01.04.2012 16:11, Michael Büsch wrote:
On Sun, 01 Apr 2012 15:29:07 +0300
Antti Palosaari<crope@xxxxxx> wrote:
buf[1] = msg[0].addr<< 1;
Maybe you have given I2C address as a "8bit" format?
Uhh, the address is leftshifted by one.
So I changed the i2c address from 0xC0 to 0x60.
That's a very common mistake, I2C addresses are 7 bit and LSB is
direction. But it is very common to see used it as a "8bit" format, 0xC0
write address and 0xc1 as a read address. Even some data-sheets have
that "wrong" naming.
There is many drivers that is wrong and causing confusion, even my old
AF9015... :]
The i2c write seems to work now. At least it doesn't complain anymore
and it sorta seems to tune to the right frequency.
But i2c read may be broken.
I had to enable the commented read code, but it still fails to read
the VCO calibration value:
[ 3101.940765] i2c i2c-8: Failed to read VCO calibration value (got 20)
It doesn't run into this check on the other af903x driver.
So I suspect an i2c read issue here.
That could be I2C adapter issue too, TUA9001 does not use it and thus
not tested at all... But for my eyes it looks logically correct still.
Attached: The patches.
Lets see.
regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
