Hi Laurent, On Wed, Mar 07, 2012 at 11:50:19AM +0100, Laurent Pinchart wrote: > Hi Sakari, > > Another comment. > > On Tuesday 06 March 2012 18:33:06 Sakari Ailus wrote: > > Collect entities which are part of the pipeline into a single bit mask. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx> > > [snip] > > > diff --git a/drivers/media/video/omap3isp/ispvideo.h > > b/drivers/media/video/omap3isp/ispvideo.h index d91bdb91..0423c9d 100644 > > --- a/drivers/media/video/omap3isp/ispvideo.h > > +++ b/drivers/media/video/omap3isp/ispvideo.h > > @@ -96,6 +96,7 @@ struct isp_pipeline { > > enum isp_pipeline_stream_state stream_state; > > struct isp_video *input; > > struct isp_video *output; > > + u32 entities; > > unsigned long l3_ick; > > unsigned int max_rate; > > atomic_t frame_number; > > Could you please update the structure documentation ? > > @entities: Bitmask of entities in the pipeline (indexed by entity ID) Sure. I'll take that from your patch. ;-) -- Sakari Ailus e-mail: sakari.ailus@xxxxxx jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html