Hello, do you exactly read the codes? Both of you refer to the codes from Montage Technology. That is why the identical in ds3000 code. in m88ds3103.c, it support the new demodulator m88ds3103 and new tuner ts2022, also backward to support ds3000 and ts2020. The firmware for ds3103 is not compatible with ds3000. and the tuning control is also different too. So does tuner ts2022. It design the new initilase logic. In your ds3000.c file, it will download firmware every time when the application tunes the transponders. Downloading firmware needs lock the firmware file and do many i2c transactions. It will slow down the channel tuning. It is unnecessary. You maybe refer to conexant cx24116 code to do that. But it is different between Montage chips and cx24116 chip. It is the right thing in cx24116, it is not for Montage chips. In m88ds3103.c, it is only one time to download the firmware not every time. It also fix the bug in reading back tuner register. In your ds3000.c file, it is wrong to do read tuner register. So it is wrong value when reading back. It support demod/tuner wake and sleep function. When the application close or not use dvb device, in m88ds3103.c it will put the demod/tuner in the sleep to save power. In ds3000.c, it is null. ............................................................. I do not want to list all let this mail become a long one. I do not want to argue with you. So what is the right thing let "Bestunar" do? They create the hardware. The end user like it and want to use it in Linux. Linux is open sourced and GPL. So every one can do change in any source code. "Bestunar" really change the code and open to the public. But they should put your copyright and name in their m88ds3103.c, is it right? For ds3000.c file, need your permission. If you deny, that they can not change it. is it right? If you agree, whatever they do. They can not put their copyright and name. is it right? 2012-02-14 nibble.max 发件人： Konstantin Dimitrov 发送时间： 2012-02-13 23:56:29 收件人： nibble.max 抄送： linux-media; Andreas Mair 主题： Re: Re: Mystique SaTiX-S2 Sky Xpress DUAL card hello, and what's exactly the different in 'm88ds3103.c' then your approach before - you just do the same and now even remove my name from the copyright, which is really ridiculous because almost all of your code is copy&paste from my code inside 'ds3000.c'. so, in 'm88ds3103.c' you take 'ds3000.c' code, make some small patches to add ds3103 support, which are mainly one array of initialization values and even this time remove my name from the copyright, while 90% of the code inside 'm88ds3103.c' is made by me - you even leave my comments from the 'ds3000.c' code letter by letter. so, if you want to claim copyright, please develop your own code that doesn't use like 90% (and even more) of mine code. On Mon, Feb 13, 2012 at 5:28 PM, nibble.max <nibble.max@xxxxxxxxx> wrote: > Hello Konstantin, > I think "Bestunar" do make the two wrong things. > One, they put the copyright without your permission. > But I doute that you copy and paste the Montage Technology's reference code > and why not put Montage copyright? > Two, they write the code based on the ds3000.c file which you created, even > they enhance and fix some bugs. > > They build the products based on Montage Technology advanced M88DS3103 chip, > which is totally a new chip different from old ds3000. > And they are the first company to adopt this new chip on the Satellite > DVB-S2 tuner cards. > They do the right thing now that create a new file named m88ds3103.c for the > new chip in linux media tree. > http://www.dvbsky.net/download/bst-patch.tar.gz > > Br, > > 2012-02-13 > ________________________________ > nibble.max > ________________________________ > 发件人： Konstantin Dimitrov > 发送时间： 2011-12-29 18:25:37 > 收件人： Andreas Mair > 抄送： linux-media > 主题： Re: Mystique SaTiX-S2 Sky Xpress DUAL card > hello Andreas, > i've checked the Linux drivers for the card you referred to and > whoever made it is breaking all the rules claiming copyright over the > whole driver adding at the beginning: > "Copyright (C) 2010 Bestunar Inc." > when they just patched the driver very slightly adding only new > initialization values - if they wish they can claim copyright only > over those small changes (even they are just number constants provided > by the chip maker). in any case that's ridiculous, because i made that > driver and the copyright notice is: > http://git.linuxtv.org/media_tree.git/blob/61c4f2c81c61f73549928dfd9f3e8f26aa36a8cf:/drivers/media/dvb/frontends/ds3000.c > Montage Technology DS3000/TS2020 - DVBS/S2 Demodulator/Tuner driver > Copyright (C) 2009 Konstantin Dimitrov <kosio.dimitrov@xxxxxxxxx> > Copyright (C) 2009 TurboSight.com > and i strongly opposed that copyright massage can be changed in the > way like they did especially over the changes they made. > also, the whole 'ds3000' driver, even it's licensed under GPL, was > submitted to the Linux kernel without my formal permission that to be > done, i.e. you can think for that as it was leaked to the Linux kernel > from third-parties and not the driver author and copyright-holder. > so, it seems to me "Bestunar Inc" is some obscure Chinese company most > probably cloning hardware rather than spent any time doing > development, which or course also don't honor the work put in > development of open-source driver for the chips they're using and try > very hard to make it look like they did it or that they did something > more significant than what they actually did. i'm sure you can > understand my position and my opinion that such companies shouldn't be > supported in any possible way. > best regards, > konstantin > On Thu, Dec 29, 2011 at 11:07 AM, Andreas Mair <amair.sob@xxxxxxxxxxxxxx> wrote: >> Hello, >> >> I'm using that card in my Linux VDR box: >> http://www.dvbshop.net/product_info.php/info/p2440_Mystique-SaTiX-S2-Sky-Xpress-DUAL--USALS--DiseqC-1-2--Win-Linux.html >> >> That's the lspci output: >> =========== SNIP ========= >> $ lspci -vvvnn >> 02:00.0 Multimedia video controller [0400]: Conexant Systems, Inc. >> CX23885 PCI Video and Audio Decoder [14f1:8852] (rev 02) >> Subsystem: Device [4254:0952] >> Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- >> ParErr- Stepping- SERR- FastB2B- DisINTx- >> Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- >> <TAbort- <MAbort- >SERR- <PERR- INTx- >> Latency: 0, Cache Line Size: 64 bytes >> Interrupt: pin A routed to IRQ 16 >> Region 0: Memory at fe400000 (64-bit, non-prefetchable) [size=2M] >> Capabilities: [40] Express (v1) Endpoint, MSI 00 >> DevCap: MaxPayload 128 bytes, PhantFunc 0, Latency L0s >> <64ns, L1 <1us >> ExtTag- AttnBtn- AttnInd- PwrInd- RBE- FLReset- >> DevCtl: Report errors: Correctable- Non-Fatal- Fatal- >> Unsupported- >> RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop+ >> MaxPayload 128 bytes, MaxReadReq 512 bytes >> DevSta: CorrErr- UncorrErr+ FatalErr- UnsuppReq+ >> AuxPwr- TransPend- >> LnkCap: Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1, >> Latency L0 <2us, L1 <4us >> ClockPM- Surprise- LLActRep- BwNot- >> LnkCtl: ASPM Disabled; RCB 64 bytes Disabled- Retrain- CommClk+ >> ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt- >> LnkSta: Speed 2.5GT/s, Width x1, TrErr- Train- >> SlotClk+ DLActive- BWMgmt- ABWMgmt- >> Capabilities: [80] Power Management version 2 >> Flags: PMEClk- DSI+ D1+ D2+ AuxCurrent=0mA >> PME(D0+,D1+,D2+,D3hot+,D3cold-) >> Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- >> Capabilities: [90] Vital Product Data >> Product Name: " >> End >> Capabilities: [a0] MSI: Enable- Count=1/1 Maskable- 64bit+ >> Address: 0000000000000000 Data: 0000 >> Capabilities: [100] Advanced Error Reporting >> UESta: DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- >> UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq+ ACSViol- >> UEMsk: DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- >> UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq- ACSViol- >> UESvrt: DLP+ SDES- TLP- FCP+ CmpltTO- CmpltAbrt- >> UnxCmplt- RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol- >> CESta: RxErr- BadTLP- BadDLLP- Rollover- Timeout- NonFatalErr- >> CEMsk: RxErr- BadTLP- BadDLLP- Rollover- Timeout- NonFatalErr- >> AERCap: First Error Pointer: 14, GenCap- CGenEn- ChkCap- ChkEn- >> Capabilities: [200] Virtual Channel <?> >> Kernel driver in use: cx23885 >> Kernel modules: cx23885 >> =========== SNAP ========= >> >> So this is different to what's written at >> http://linuxtv.org/wiki/index.php/Mystique_SaTiX-S2_Dual >> I guess it's more like that card: http://linuxtv.org/wiki/index.php/DVBSKY_S952 >> >> I'm using the drivers found at http://www.dvbsky.net/Support.html >> (http://www.dvbsky.net/download/linux-3.0-media-20111024-bst-111205.tar.gz). >> I didn't get that card running with kernel 3.0.6 and haven't seen >> support for that card in any linuxtv.org repository I've looked into. >> >> Now I wonder: >> - Who is responsible for that drivers? Someone at DVBSky.net? >> - Is there a chance to get that drivers into the kernel? >> - Has anybody else on this list this card running? >> >> Best regards, >> Andreas >> -- >> http://andreas.vdr-developer.org --- VDRAdmin-AM & EnigmaNG & VDRSymbols >> VDR user #303 >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-media" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html . ?韬{.n?????%??檩??w?{.n???{炳g???^n?■???h?璀?｛?夸z罐?+€?zf＂?????i?????_璁?:+v??撸?
