On Jan 25 17:11, Jarod Wilson wrote: > Corinna Vinschen wrote: > >Hi Jarod, > > > >On Jan 25 15:56, Jarod Wilson wrote: > >>This patch is just a minor update to one titled "imon: Input from ffdc > >>device type ignored" from Corinna Vinschen. An earlier patch to prevent > >>an oops when we got early callbacks also has the nasty side-effect of > >>wedging imon hardware, as we don't acknowledge the urb. Rework the check > >>slightly here to bypass processing the packet, as the driver isn't yet > >>fully initialized, but still acknowlege the urb and submit a new rx_urb. > >>Do this for both interfaces -- irrelevant for ffdc hardware, but > >>relevant for newer hardware, though newer hardware doesn't spew the > >>constant stream of data as soon as the hardware is initialized like the > >>older ffdc devices, so they'd be less likely to trigger this anyway... > > > >just a question, wouldn't it make sense to bump the version number of the > >module to 0.9.4? Or do you do that for functional changes only? > > I've not been terribly consistent with it, but it does seem the last > time I bumped the version number *was* to have an easy way to tell > if a particular fix was included or not. We can bump it here too, > doesn't really matter to me. Could be helpful here, too, I guess. Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
