Re: [PATCH] imon: don't wedge hardware after early callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jarod,

On Jan 25 15:56, Jarod Wilson wrote:
> This patch is just a minor update to one titled "imon: Input from ffdc
> device type ignored" from Corinna Vinschen. An earlier patch to prevent
> an oops when we got early callbacks also has the nasty side-effect of
> wedging imon hardware, as we don't acknowledge the urb. Rework the check
> slightly here to bypass processing the packet, as the driver isn't yet
> fully initialized, but still acknowlege the urb and submit a new rx_urb.
> Do this for both interfaces -- irrelevant for ffdc hardware, but
> relevant for newer hardware, though newer hardware doesn't spew the
> constant stream of data as soon as the hardware is initialized like the
> older ffdc devices, so they'd be less likely to trigger this anyway...

just a question, wouldn't it make sense to bump the version number of the
module to 0.9.4?  Or do you do that for functional changes only?


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux