On Fri, 6 Jan 2012 19:14:42 +0100 Sylwester Nawrocki <snjw23@xxxxxxxxx> wrote: > The JPEG compression quality control is currently done by means of the > VIDIOC_S/G_JPEGCOMP ioctls. As the quality field of struct v4l2_jpgecomp > is being deprecated, we add the V4L2_CID_JPEG_COMPRESSION_QUALITY control, > so after the deprecation period VIDIOC_S/G_JPEGCOMP ioctl handlers can be > removed, leaving the control the only user interface for compression > quality configuration. This patch works, but it may be simplified. Instead of a '.set' pointer, the control descriptor for QUALITY may contain a '.set_control' pointing to a function which just does jpeg_set_qual(sd->jpeg_hdr, sd->ctrls[QUALITY].val); this function being also be called from the obsoleted function sd_setquality(). Also, in sd_config, there is no need to initialize the variable sd->ctrls[QUALITY].val. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html