Re: [PATCH 2/2] [media] af9005, af9015: use symbolic names for USB id table indices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Al 07/01/12 09:11, En/na Jonathan Nieder ha escrit:
> The af9005_properties and af9015_properties tables make use of USB ids
> from the USB id tables with hardcoded indices, as in
> "&af9015_usb_table[30]".  Adding new entries before the end breaks
> such references, so everyone has had to carefully tiptoe to only add
> entries at the end of the list.
> 
> In the spirit of "dw2102: use symbolic names for dw2102_table
> indices", use C99-style initializers with symbolic names for each
> index to avoid this.  In the new regime, properties tables referring
> to the USB ids have names like "&af9015_usb_table[CINERGY_T_STICK_RC]"
> that do not change meaning when items in the USB id table are
> reordered.
> 
> Encouraged-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx>

Seems good to me, didn't know you could do that in C.

Acked-by: Luca Olivetti <luca@xxxxxxxxxxx>

Bye
-- 
Luca
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux