On Friday, December 23, 2011 12:44:46 AM Jonathan Nieder wrote: > Hi, > > Eduard Bloch wrote[1]: > > current revision of the Cinergy S2 USB box from Terratec seems to use > > another USB-IDs. The manufacturer provides patches at > > http://linux.terratec.de/tv_en.html and it seems like the only > > difference is really just the new ID and a couple of init flag changes. > > > > Their patch is not exactly for the linux-3.x tree but for the current > > s2-liplianin drivers, OTOH they still look similar enough and porting > > the patch was straight-forward. I also added the patch for Terratec S7 > > which is not tested yet but shouldn't do any harm. > > [...] > > Eduard, meet the LinuxTV project. linux-media folks, meet Eduard. > Patch follows. > > Eduard: may we have your sign-off? Please see > Documentation/SubmittingPatches, section 12 "Sign your work" for what > this means. > > My only other hint is that it would be better to add the new device > IDs in some logical place in the list near the older ones, instead of > at the end where it is more likely to collide with other patches in > flight. So if rerolling the patches, it might be useful to do that. Due to the use of the reference in the USB-id table adding the new set at the end of the list is actually the best way. Adding them in the middle will cause a lot of changes and bugs. Except the Signed-off-by everything is fine to my eyes. -- Patrick -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
