re: [media] cx23885-dvb: Remove a dirty hack that would require DVBv3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Mauro Carvalho Chehab,

This is a semi-automatic email about new static checker warnings.

The patch a7d44baaed0a: "[media] cx23885-dvb: Remove a dirty hack 
that would require DVBv3" from Dec 26, 2011, leads to the following 
Smatch complaint:

drivers/media/video/cx23885/cx23885-dvb.c +135 cx23885_dvb_gate_ctrl()
	 error: we previously assumed 'fe' could be null (see line 128)

drivers/media/video/cx23885/cx23885-dvb.c
   127	
   128		if (fe && fe->dvb.frontend && fe->dvb.frontend->ops.i2c_gate_ctrl)
                    ^^
Old condition.

   129			fe->dvb.frontend->ops.i2c_gate_ctrl(fe->dvb.frontend, open);
   130	
   131		/*
   132		 * FIXME: Improve this path to avoid calling the
   133		 * cx23885_dvb_set_frontend() every time it passes here.
   134		 */
   135		cx23885_dvb_set_frontend(fe->dvb.frontend);
                                         ^^^^
New dereference.

   136	}
   137	

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux