On Dec 31 Jonathan Nieder wrote: > It is not common for dvb_net_init to fail, but after the patch > "dvb_net_init: return -errno on error" it can fail due to running out > of memory. Handle this. > From an audit of dvb_net_init callers. > > Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx> Reviewed-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> [...] > --- a/drivers/media/dvb/firewire/firedtv-dvb.c > +++ b/drivers/media/dvb/firewire/firedtv-dvb.c > @@ -203,7 +203,9 @@ int fdtv_dvb_register(struct firedtv *fdtv, const > char *name) if (err) > goto fail_rem_frontend; > > - dvb_net_init(&fdtv->adapter, &fdtv->dvbnet, &fdtv->demux.dmx); > + err = dvb_net_init(&fdtv->adapter, &fdtv->dvbnet, > &fdtv->demux.dmx); > + if (err) > + goto fail_disconnect_frontend; > > fdtv_frontend_init(fdtv, name); > err = dvb_register_frontend(&fdtv->adapter, &fdtv->fe); > @@ -218,6 +220,7 @@ int fdtv_dvb_register(struct firedtv *fdtv, const > char *name) > fail_net_release: > dvb_net_release(&fdtv->dvbnet); > +fail_disconnect_frontend: > fdtv->demux.dmx.close(&fdtv->demux.dmx); > fail_rem_frontend: > fdtv->demux.dmx.remove_frontend(&fdtv->demux.dmx, > &fdtv->frontend); -- Stefan Richter -=====-==-== ==-- ===== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
