Mauro Carvalho Chehab wrote: > Subject: [media] cx88-dvb avoid dangling core->gate_ctrl pointer > Author: David Fries <david@xxxxxxxxx> > Date: Thu Dec 15 01:59:20 2011 -0300 > > dvb_register calls videobuf_dvb_register_bus, but if that returns > a failure the module will be unloaded without clearing the > value of core->gate_ctrl which will cause an oops in macros > called from video_open in cx88-video.c > > Signed-off-by: David Fries <David@xxxxxxxxx> > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> > Cc: Istvan Varga <istvan_v@xxxxxxxxxx> > Cc: Jonathan Nieder <jrnieder@xxxxxxxxx> > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> For what it's worth, Acked-by: Jonathan Nieder <jrnieder@xxxxxxxxx> Thanks. Here are some patches to stop producing the spurious -ENOMEM in the first place, and to start checking the return value from dvb_net_init in other contexts more diligently. Untested. Bug reports, patches in the same vein on top (just try "git grep -Ovi -e dvb_net_init"), and other thoughts of all kinds welcome. Jonathan Nieder (9): [media] DVB: dvb_net_init: return -errno on error [media] videobuf-dvb: avoid spurious ENOMEM when CONFIG_DVB_NET=n [media] dvb-bt8xx: use goto based exception handling [media] ttusb-budget: use goto for exception handling [media] flexcop: handle errors from dvb_net_init [media] dvb-bt8xx: handle errors from dvb_net_init [media] dm1105: handle errors from dvb_net_init [media] dvb-usb: handle errors from dvb_net_init [media] firedtv: handle errors from dvb_net_init drivers/media/dvb/b2c2/flexcop.c | 7 ++- drivers/media/dvb/bt8xx/dvb-bt8xx.c | 65 +++++++++++---------- drivers/media/dvb/dm1105/dm1105.c | 5 +- drivers/media/dvb/dvb-core/dvb_net.c | 4 +- drivers/media/dvb/dvb-usb/dvb-usb-dvb.c | 8 ++- drivers/media/dvb/firewire/firedtv-dvb.c | 5 +- drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c | 40 +++++++------ drivers/media/video/videobuf-dvb.c | 7 +- 8 files changed, 82 insertions(+), 59 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
